feat: Fetch tags from GitHub, use only latest from SDP release line#32
Merged
Conversation
adwk67
reviewed
May 13, 2026
Member
adwk67
left a comment
adwk67
left a comment
There was a problem hiding this comment.
This looks and renders OK. Just one question - I see a lot of warnings like this:
2026/05/13 15:06:32 Indexing repo airflow-operator ...
...
2026/05/13 15:06:44 WARNING: spec.validation.openAPIV3Schema.properties[spec].properties[clusterConfig].default.credentialsSecret: Invalid value: "null": credentialsSecret in body must be of type string: "null"
2026/05/13 15:06:44 Found 1 CRDs
2026/05/13 15:06:44 ... at tag: 23.7.0 ...
2026/05/13 15:06:46 found files: 1
2026/05/13 15:06:46 WARNING: spec.validation.openAPIV3Schema.properties[spec].properties[clusterConfig].default.credentialsSecret: Invalid value: "null": credentialsSecret in body must be of type string: "null"
2026/05/13 15:06:46 Found 2 CRDs
although everything renders OK:
adwk67
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Member
Author
|
I think the warnings have been there for years and are totally unrelated to this change. |
adwk67
approved these changes
May 13, 2026
sbernauer
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed by stackabletech/crddocs#58